search

EventStore / EventStoreDB-Client-Java

Official Asynchronous Java 8+ Client Library for EventStoreDB 20.6+
https://eventstore.com
Apache License 2.0
61 stars 19 forks source link

Allow the user to use whatever gRPC implementation they want. #251

Open YoEight opened 8 months ago

YoEight commented 8 months ago

Changed: Allow the user to use whatever gRPC implementation they want.

Fixes #249

This patch allows the user to use whatever gRPC implementation they want which is valuable if you want to use the client in Android for example. As a consequence, users will have to import grpc-netty, grpc-netty-shaded or grpc-okhttp depending on their situation.

YoEight commented 8 months ago

I would put that PR on hold because I'm unable to disable certificate verification using Grpc.newChannelBuilderForAddress and TlsChannelCredentials only. Setting a custom insecure trust manager and a hostname verifier do absolutely nothing. Will investigate what the folks working on grpc-netty-shaded did to make that possible.