Question: throwOnAppendFailure removed, was it unused?

EventStore / EventStoreDB-Client-Java

Official Asynchronous Java 8+ Client Library for EventStoreDB 20.6+

https://eventstore.com

Apache License 2.0

61 stars 19 forks source link

Closed TomMante closed 8 months ago

TomMante commented 8 months ago

Hello,

I am currently looking to upgrade from 4.3.0 to 5.2.0 and looking at the changes, i saw that throwOnAppendFailure was removed from the connection settings in this pr: https://github.com/EventStore/EventStoreDB-Client-Java/pull/243

I was trying to see if it was used before or not, it seems not, could you confirm that this is an unused parameter? Can I just ignore it?

Thank you!

YoEight commented 8 months ago

Hey @TomMante,

Rest assured, throwOnAppendFailure was never implemented in the first place in the Java client. The Java client always throws on append failure.