EventStore / EventStoreDB-Client-Java

Official Asynchronous Java 8+ Client Library for EventStoreDB 20.6+
https://eventstore.com
Apache License 2.0
63 stars 20 forks source link

Unify error handling behavior for subscriptions. #99

Closed dpasek-senacor closed 3 years ago

dpasek-senacor commented 3 years ago

The error handling behavior between persistent and non-persistent subscriptions is inconsistent and partly erroneous:

This pull requests unifies the behavior and avoids duplicate calls to the error listener.

YoEight commented 3 years ago

Nice catch by the way!

dpasek-senacor commented 3 years ago

@YoEight

Please stop making my life easier

😂

Maybe just as an explanation: we are currently preparing the migration of our EventStoreDB integration from the old (unofficial) ESJC (see: https://github.com/msemys/esjc no longer actively developed as TCP protocol is deprecated) to your new gRPC Java client. Our integration has quite an extensive test coverage and therefore it is quite easy for us to find issues in the EventStoreDB client. As we want to proceed with the migration it is also easier for me to provide the patches myself instead of writing issue reports or feature requests and hoping things will be done by other people. 😉