search

EventVisionLibrary / evl

Event Vision Library (EVL)
BSD 3-Clause "New" or "Revised" License
26 stars 4 forks source link

followed cpplint #10

Closed shiba24 closed 6 years ago

shiba24 commented 6 years ago

followed cpplint except for (unapproved C++11 header) and 'Include the directory when naming .h files'.

I think we are able to merge once except for them.

To check cpplint:

pip install cpplint
cpplint FILEPATH
shiba24 commented 6 years ago

This PR is for issue #9

shiba24 commented 6 years ago

とりあえずレビュー依頼出しましたが、lintに従うだけなのでほとんどチェックしなくて良いはずです。その代わりほぼ全てのソースコードに変更点があります。忙しかったらReviewerを割り当て変えてください。 @rikky0611

rikky0611 commented 6 years ago

I cannot succeed in cmake in this branch

rikky0611 commented 6 years ago

Now I succeeded, thanks. LGTM.