search

Eventual-Inc / Daft

Distributed DataFrame for Python designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
1.71k stars 98 forks source link

[EXPRESSIONS] `.sqrt` #1918

Closed colin-ho closed 2 days ago

colin-ho commented 2 months ago

sqrt()

Compute the square root of the expression.

chandbud5 commented 2 months ago

I would like to contribute to this issue, if its not already done

colin-ho commented 2 months ago

Awesome, assigning this issue to you. Thanks @chandbud5 !

colin-ho commented 3 weeks ago

Hey @chandbud5 ! Any updates on this issue?

chandbud5 commented 2 weeks ago

I did try it out, but I've been struggling to make progress on this issue, since I am not strong on rust. I think it would be better for someone else to take it on. Could you please unassign me from this issue? I appreciate the opportunity to contribute, and I look forward to picking up other issues that might be a better fit for my skills. Sorry for any inconvenience caused.

colin-ho commented 2 weeks ago

I did try it out, but I've been struggling to make progress on this issue, since I am not strong on rust. I think it would be better for someone else to take it on. Could you please unassign me from this issue? I appreciate the opportunity to contribute, and I look forward to picking up other issues that might be a better fit for my skills. Sorry for any inconvenience caused.

No worries at all!

dmaymay commented 1 week ago

Hey @colin-ho , this seemed a tad easier than .clip() to start with so I wanted to give it a try, but I ran into a similar issue, I made a draft pull request on this to start with.

This solution "works" but similarly, it returns the original type, losing precision in the output. I wrote another solution in the commented out code in array/ops/sqrt.rs but ran into the same issue as .clip() when running it.