Open colin-ho opened 4 weeks ago
Currently, the dt.hour() expression only works on Datetime columns. We should allow this to work on Time columns as well.
Example of desired behaviour:
import daft import datetime df = daft.from_pydict({"data":[datetime.datetime.now().time()]}) df = df.select(df["data"].dt.hour()) df = df.collect() print(df)
Also, the docstrings for the dt.hour expression should be fixed as well.
dt.hour
@colin-ho i would like to work on this issue
Awesome, assigning this to you, thanks @KekmaTime !!
Currently, the dt.hour() expression only works on Datetime columns. We should allow this to work on Time columns as well.
Example of desired behaviour:
Also, the docstrings for the
dt.hour
expression should be fixed as well.