Eventual-Inc / Daft

Distributed DataFrame for Python designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
1.79k stars 108 forks source link

[FEAT] Enable Ruff #2121

Closed samster25 closed 1 month ago

samster25 commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.09%. Comparing base (e2c6fec) to head (04915bb). Report is 5 commits behind head on main.

:exclamation: Current head 04915bb differs from pull request most recent head 649d736. Consider uploading reports for the commit 649d736 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #2121 +/- ## ========================================== + Coverage 85.05% 85.09% +0.04% ========================================== Files 68 68 Lines 7332 7326 -6 ========================================== - Hits 6236 6234 -2 + Misses 1096 1092 -4 ``` | [Files](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [daft/\_\_init\_\_.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9fX2luaXRfXy5weQ==) | `24.24% <ø> (ø)` | | | [daft/delta\_lake/delta\_lake\_scan.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Fdelta_lake%2Fdelta_lake_scan.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9kZWx0YV9sYWtlL2RlbHRhX2xha2Vfc2Nhbi5weQ==) | `86.66% <100.00%> (ø)` | | | [daft/execution/execution\_step.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Fexecution%2Fexecution_step.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9leGVjdXRpb24vZXhlY3V0aW9uX3N0ZXAucHk=) | `93.39% <100.00%> (-0.02%)` | :arrow_down: | | [daft/execution/physical\_plan.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Fexecution%2Fphysical_plan.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9leGVjdXRpb24vcGh5c2ljYWxfcGxhbi5weQ==) | `94.86% <100.00%> (ø)` | | | [daft/execution/rust\_physical\_plan\_shim.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Fexecution%2Frust_physical_plan_shim.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9leGVjdXRpb24vcnVzdF9waHlzaWNhbF9wbGFuX3NoaW0ucHk=) | `95.83% <100.00%> (ø)` | | | [daft/filesystem.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Ffilesystem.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9maWxlc3lzdGVtLnB5) | `60.89% <ø> (ø)` | | | [daft/hudi/hudi\_scan.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Fhudi%2Fhudi_scan.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9odWRpL2h1ZGlfc2Nhbi5weQ==) | `82.35% <ø> (ø)` | | | [daft/hudi/pyhudi/table.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Fhudi%2Fpyhudi%2Ftable.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9odWRpL3B5aHVkaS90YWJsZS5weQ==) | `97.61% <ø> (ø)` | | | [daft/io/\_delta\_lake.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Fio%2F_delta_lake.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9pby9fZGVsdGFfbGFrZS5weQ==) | `89.36% <ø> (ø)` | | | [daft/logical/builder.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree&filepath=daft%2Flogical%2Fbuilder.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9sb2dpY2FsL2J1aWxkZXIucHk=) | `91.52% <100.00%> (-0.08%)` | :arrow_down: | | ... and [11 more](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2121?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | |
MeepoWin commented 1 month ago

Amazing! I'm looking forward to how much this will reduce pre-commit wait times. :)

samster25 commented 1 month ago

Amazing! I'm looking forward to how much this will reduce pre-commit wait times. :)

@MeepoWin me too! There's also so many Ruff rules to avoid footguns :)

samster25 commented 1 month ago

Do we want to exclude vendored files, like the cloudpickle code? We'd ideally like to keep vendored files as close to their source as possible, in case we want to pull in upstream changes.

Done! now ignore the cloud pickle files.