search

Eventual-Inc / Daft

Distributed DataFrame for Python designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
1.76k stars 105 forks source link

.sqrt() expression #2180

Closed dmaymay closed 2 weeks ago

dmaymay commented 3 weeks ago

Working .sqrt() function. Casting integers to appropriate float types :)

colin-ho commented 2 weeks ago

Hey @dmaymay ! This PR looks ready to merge, if you could just help remove this one line here that's no longer needed that'd be great. Also seems like there's a merge conflict, I checked it out and it should just be a simple one line change :)

dmaymay commented 2 weeks ago

@colin-ho We good to merge?

colin-ho commented 2 weeks ago

@colin-ho We good to merge?

Yep! Just did a rebase to inspect the file changes a lil easier, but all good and merged now, thanks @dmaymay 😆

colin-ho commented 2 weeks ago

Also congrats on first PR!!

jaychia commented 2 weeks ago

Congrats on your first PR 🤓 @dmaymay

samster25 commented 1 week ago

great job @dmaymay!