search

Eventual-Inc / Daft

Distributed DataFrame for Python designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
1.76k stars 105 forks source link

[CHORE] Return &str for expression name #2224

Closed colin-ho closed 1 week ago

colin-ho commented 2 weeks ago

We return a DaftResult<&str> for expression names, but currently there's no case that would raise an error. Having the return type as &str should be sufficient.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.59%. Comparing base (da991c5) to head (ac5ee6e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2224/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/2224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #2224 +/- ## ======================================= Coverage 85.59% 85.59% ======================================= Files 71 71 Lines 7586 7586 ======================================= Hits 6493 6493 Misses 1093 1093 ```