search

Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.39k stars 170 forks source link

implement `_repr_mimebundle_` for dataframe #2598

Open universalmind303 opened 4 months ago

universalmind303 commented 4 months ago

Is your feature request related to a problem? Please describe. Some jupyter frontends don't support '_reprhtml` (such as zed). Implementing _reprmimebundle will ensure dataframes are always properly displayed/formatted.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context https://github.com/zed-industries/zed/issues/15555#issuecomment-2263764142

universalmind303 commented 3 months ago

So i guess there is a bug in vscode https://github.com/microsoft/vscode-notebook-renderers/issues/189 and it won't render application/vnd.dataresource+json mimetypes, so if this is added, vcsode jupyter will no longer work by default. So this is effectively blocked until vscode can handle this mimetype.

rgbkrk commented 3 months ago

cc @donjayamanne