search

Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[FEAT] enable decimal between #3154

Closed samster25 closed 3 weeks ago

samster25 commented 3 weeks ago
codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #3154 will not alter performance

Comparing sammy/enable-decimal-between (da1fc33) with main (c78fef4)

Summary

✅ 17 untouched benchmarks

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (c78fef4) to head (da1fc33). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-schema/src/dtype.rs 66.66% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3154/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3154 +/- ## ========================================== - Coverage 78.73% 78.73% -0.01% ========================================== Files 621 621 Lines 75187 75191 +4 ========================================== + Hits 59198 59199 +1 - Misses 15989 15992 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3154?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-core/src/array/ops/between.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3154?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Farray%2Fops%2Fbetween.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvYXJyYXkvb3BzL2JldHdlZW4ucnM=) | `86.66% <ø> (ø)` | | | [src/daft-core/src/series/ops/between.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3154?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Fseries%2Fops%2Fbetween.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvc2VyaWVzL29wcy9iZXR3ZWVuLnJz) | `75.00% <100.00%> (+3.12%)` | :arrow_up: | | [src/daft-schema/src/dtype.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3154?src=pr&el=tree&filepath=src%2Fdaft-schema%2Fsrc%2Fdtype.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtc2NoZW1hL3NyYy9kdHlwZS5ycw==) | `83.67% <66.66%> (-0.27%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3154/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)