search

Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.39k stars 170 forks source link

[CHORE] implement mean and stddev for decimal #3159

Closed samster25 closed 3 weeks ago

samster25 commented 4 weeks ago

closes: https://github.com/Eventual-Inc/Daft/issues/3157

codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #3159 will degrade performances by 16.11%

Comparing sammy/decimal-aggs (f903caf) with main (6e28b3f)

Summary

⚡ 1 improvements ❌ 1 regressions ✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sammy/decimal-aggs Change
⚡ test_iter_rows_first_row[100 Small Files] 306.5 ms 262.4 ms +16.77%
❌ test_show[100 Small Files] 50.1 ms 59.8 ms -16.11%
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 67.19577% with 62 lines in your changes missing coverage. Please review.

Project coverage is 79.10%. Comparing base (6e28b3f) to head (f903caf). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-dsl/src/functions/agg/mod.rs 57.53% 31 Missing :warning:
src/daft-core/src/datatypes/agg_ops.rs 62.85% 13 Missing :warning:
src/daft-core/src/datatypes/infer_datatype.rs 47.36% 10 Missing :warning:
src/daft-core/src/series/ops/agg.rs 73.33% 8 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3159 +/- ## ========================================== - Coverage 79.12% 79.10% -0.03% ========================================== Files 641 642 +1 Lines 78151 78294 +143 ========================================== + Hits 61837 61931 +94 - Misses 16314 16363 +49 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-core/src/array/iterator.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Farray%2Fiterator.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvYXJyYXkvaXRlcmF0b3IucnM=) | `100.00% <ø> (ø)` | | | [src/daft-core/src/array/ops/mean.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Farray%2Fops%2Fmean.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvYXJyYXkvb3BzL21lYW4ucnM=) | `100.00% <100.00%> (ø)` | | | [src/daft-core/src/datatypes/mod.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Fdatatypes%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvZGF0YXR5cGVzL21vZC5ycw==) | `40.00% <ø> (ø)` | | | [src/daft-dsl/src/expr/mod.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-dsl%2Fsrc%2Fexpr%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtZHNsL3NyYy9leHByL21vZC5ycw==) | `78.07% <100.00%> (+0.13%)` | :arrow_up: | | [src/daft-dsl/src/functions/mod.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-dsl%2Fsrc%2Ffunctions%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtZHNsL3NyYy9mdW5jdGlvbnMvbW9kLnJz) | `84.21% <ø> (ø)` | | | [src/daft-functions/src/list/mean.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-functions%2Fsrc%2Flist%2Fmean.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtZnVuY3Rpb25zL3NyYy9saXN0L21lYW4ucnM=) | `61.76% <100.00%> (ø)` | | | [...ft-physical-plan/src/physical\_planner/translate.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-physical-plan%2Fsrc%2Fphysical_planner%2Ftranslate.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtcGh5c2ljYWwtcGxhbi9zcmMvcGh5c2ljYWxfcGxhbm5lci90cmFuc2xhdGUucnM=) | `95.59% <100.00%> (+0.01%)` | :arrow_up: | | [src/daft-core/src/series/ops/agg.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Fseries%2Fops%2Fagg.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvc2VyaWVzL29wcy9hZ2cucnM=) | `77.14% <73.33%> (-0.50%)` | :arrow_down: | | [src/daft-core/src/datatypes/infer\_datatype.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Fdatatypes%2Finfer_datatype.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvZGF0YXR5cGVzL2luZmVyX2RhdGF0eXBlLnJz) | `81.53% <47.36%> (ø)` | | | [src/daft-core/src/datatypes/agg\_ops.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Fdatatypes%2Fagg_ops.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvZGF0YXR5cGVzL2FnZ19vcHMucnM=) | `72.91% <62.85%> (-27.09%)` | :arrow_down: | | ... and [1 more](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3159/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)