Closed colin-ho closed 2 weeks ago
Comparing colin/streaming-catalog-writes-2
(073b2a5) with main
(8ed174c)
✅ 17
untouched benchmarks
Attention: Patch coverage is 75.55556%
with 110 lines
in your changes missing coverage. Please review.
Project coverage is 79.13%. Comparing base (
8817a08
) to head (073b2a5
). Report is 12 commits behind head on main.
Implements streaming Iceberg and Delta writes for swordfish. Most of the write scaffolding has already been implemented in https://github.com/Eventual-Inc/Daft/pull/2992, this PR implements the Iceberg/Delta specific functionalities.
A quick TLDR on swordfish writes:
daft-writer
crate.Notes:
add_missing_columns
stuff an explicit projection. It was a lil cleaner this way instead of having swordfish implementadd_missing_columns
internally.