Open raunakab opened 3 weeks ago
Comparing feat/infra
(e908742) with main
(ec39dc0)
❌ 1
regressions
✅ 16
untouched benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmark | main |
feat/infra |
Change | |
---|---|---|---|---|
❌ | test_iter_rows_first_row[100 Small Files] |
264.6 ms | 404.6 ms | -34.59% |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.37%. Comparing base (
ec39dc0
) to head (e908742
).
🚨 Try these New Features:
Example: https://github.com/Eventual-Inc/Daft/actions/runs/11926775586
Run by @desmondcheongzx. Run was submitted locally using the gh
CLI tool. Invocation was:
gh workflow run build-commit-run-tpch.yaml --ref $BRANCH_NAME -f skip_questions=$SKIP_QUESTIONS
Tagging @colin-ho. You recently touched the benchmarking/tpch/__main__.py
file. Just wanted to run some of those changes by you first.
Overview
Create new GHA workflow for building a commit and running tpch against it.
Notes
There are 2 main workflows:
build-commit.yaml
run-tpch.yaml
The final workflow,
build-commit-run-tpch.yaml
just runs the above two in a sequential order.I've also made some changes to
benchmarking/tpch/__main__.py
. Namely:DAFT
to the ray-runtime-env variables that's sent during ray-cluster initialization.daft
module to ray-cluster during initialization.I've summarized the workflows individually down below:
build-commit workflow
run-tpch workflow
benchmarking.tpch
benchmarkbuild-commit-run-tpch workflow
build-commit
job (1st one) to the input of therun-tpch
job (2nd one)