search

Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.39k stars 170 forks source link

[PERF] Harden GCP Retries #3253

Closed samster25 closed 2 weeks ago

samster25 commented 2 weeks ago
codspeed-hq[bot] commented 2 weeks ago

CodSpeed Performance Report

Merging #3253 will improve performances by 28.43%

Comparing sammy/gcp-retry (0cf8028) with main (e27e2f5)

Summary

⚡ 1 improvements ✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main sammy/gcp-retry Change
⚡ test_show[100 Small Files] 40.7 ms 31.7 ms +28.43%
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 8.64198% with 148 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (e27e2f5) to head (0cf8028). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-io/src/google_cloud.rs 0.00% 84 Missing :warning:
src/common/io-config/src/python.rs 0.00% 39 Missing :warning:
src/daft-sql/src/modules/config.rs 0.00% 14 Missing :warning:
src/common/io-config/src/gcs.rs 56.00% 11 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3253 +/- ## ========================================== - Coverage 77.80% 77.66% -0.14% ========================================== Files 645 645 Lines 79917 80056 +139 ========================================== Hits 62177 62177 - Misses 17740 17879 +139 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/common/io-config/src/gcs.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253?src=pr&el=tree&filepath=src%2Fcommon%2Fio-config%2Fsrc%2Fgcs.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2NvbW1vbi9pby1jb25maWcvc3JjL2djcy5ycw==) | `42.42% <56.00%> (-13.14%)` | :arrow_down: | | [src/daft-sql/src/modules/config.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253?src=pr&el=tree&filepath=src%2Fdaft-sql%2Fsrc%2Fmodules%2Fconfig.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtc3FsL3NyYy9tb2R1bGVzL2NvbmZpZy5ycw==) | `1.83% <0.00%> (-0.07%)` | :arrow_down: | | [src/common/io-config/src/python.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253?src=pr&el=tree&filepath=src%2Fcommon%2Fio-config%2Fsrc%2Fpython.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2NvbW1vbi9pby1jb25maWcvc3JjL3B5dGhvbi5ycw==) | `50.48% <0.00%> (-3.38%)` | :arrow_down: | | [src/daft-io/src/google\_cloud.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253?src=pr&el=tree&filepath=src%2Fdaft-io%2Fsrc%2Fgoogle_cloud.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtaW8vc3JjL2dvb2dsZV9jbG91ZC5ycw==) | `0.00% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3253/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)