Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[CHORE] Possibility to create environment with system installed uv #3281

Closed maruschin closed 1 week ago

maruschin commented 1 week ago

I encountered an inconvenient dependency on a pre-installed version of Python. It is very convenient to create an environment with the required version via uv.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3281 will degrade performances by 13.17%

Comparing maruschin:main (6ada75b) with main (5115c32)

Summary

⚡ 1 improvements ❌ 1 regressions ✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main maruschin:main Change
test_iter_rows_first_row[100 Small Files] 260.7 ms 193.4 ms +34.76%
test_show[100 Small Files] 42.4 ms 48.8 ms -13.17%
jaychia commented 1 week ago

IIUC this PR means that instead of:

We now allow for:

I'm not the most familiar with uv, but would it not be the most reproducible developer experience if uv were to manage everything, including the Python installation? I know we've had issues in the past with inconsistent system installs of Python.

maruschin commented 1 week ago

@jaychia it's most like:

uv does not depend on Python and can be installed on its own.

jaychia commented 1 week ago

Makes sense, thanks for the contribution!