Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[BUG] Partially qualified joins `join a.x = y` and `join x = b.y` #3290

Closed universalmind303 closed 1 week ago

universalmind303 commented 1 week ago

previously we only supported either fully qualified a.x = b.y or no qualifiers x = y. this PR fixes this so we can use any combination of fully and partially qualified: so all of the following combinations are now supported.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3290 will degrade performances by 23.56%

Comparing universalmind303:partially-qualified-joins (a53da24) with main (4470192)

Summary

❌ 1 regressions ✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:partially-qualified-joins Change
test_show[100 Small Files] 32 ms 41.9 ms -23.56%
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (0720ffc) to head (0dc0e1f). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-sql/src/planner.rs 84.74% 9 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3290/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3290 +/- ## ======================================= Coverage 77.50% 77.50% ======================================= Files 666 666 Lines 81326 81358 +32 ======================================= + Hits 63029 63059 +30 - Misses 18297 18299 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3290?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-sql/src/planner.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3290?src=pr&el=tree&filepath=src%2Fdaft-sql%2Fsrc%2Fplanner.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtc3FsL3NyYy9wbGFubmVyLnJz) | `69.17% <84.74%> (+0.23%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3290/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)