Closed universalmind303 closed 1 week ago
Comparing universalmind303:partially-qualified-joins
(a53da24) with main
(4470192)
❌ 1
regressions
✅ 16
untouched benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmark | main |
universalmind303:partially-qualified-joins |
Change | |
---|---|---|---|---|
❌ | test_show[100 Small Files] |
32 ms | 41.9 ms | -23.56% |
Attention: Patch coverage is 84.74576%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 77.50%. Comparing base (
0720ffc
) to head (0dc0e1f
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/daft-sql/src/planner.rs | 84.74% | 9 Missing :warning: |
previously we only supported either fully qualified
a.x = b.y
or no qualifiersx = y
. this PR fixes this so we can use any combination of fully and partially qualified: so all of the following combinations are now supported.x = y
x = b.y
y = x
y = a.x
a.x = y
a.x = b.y
b.y = x
b.y = a.x