Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[FEAT]: connect—add parquet #3292

Closed andrewgazelka closed 4 days ago

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3292 will degrade performances by 33.5%

Comparing andrew/connect-parquet2 (e5b736e) with main (bb506a4)

Summary

⚡ 1 improvements ❌ 2 regressions ✅ 14 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-parquet2 Change
test_count[1 Small File] 3.4 ms 4 ms -14.9%
test_iter_rows_first_row[100 Small Files] 402 ms 346.9 ms +15.9%
test_show[100 Small Files] 15.8 ms 23.8 ms -33.5%
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 67.82842% with 120 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (d978058) to head (288cc90). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/logical_plan.rs 44.73% 63 Missing :warning:
src/daft-connect/src/op/execute/write.rs 80.00% 22 Missing :warning:
src/daft-connect/src/op/execute/root.rs 73.13% 18 Missing :warning:
src/daft-connect/src/main.rs 0.00% 10 Missing :warning:
src/daft-connect/src/lib.rs 33.33% 6 Missing :warning:
src/daft-logical-plan/src/source_info/mod.rs 95.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3292 +/- ## ========================================== - Coverage 77.69% 77.46% -0.24% ========================================== Files 666 666 Lines 81131 81565 +434 ========================================== + Hits 63037 63182 +145 - Misses 18094 18383 +289 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-connect/src/op/execute.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Fop%2Fexecute.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvb3AvZXhlY3V0ZS5ycw==) | `100.00% <100.00%> (ø)` | | | [src/daft-connect/src/translation/schema.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Fschema.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vc2NoZW1hLnJz) | `0.00% <ø> (ø)` | | | [src/daft-logical-plan/src/builder.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-logical-plan%2Fsrc%2Fbuilder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtbG9naWNhbC1wbGFuL3NyYy9idWlsZGVyLnJz) | `91.67% <100.00%> (-0.54%)` | :arrow_down: | | [src/daft-schema/src/schema.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-schema%2Fsrc%2Fschema.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtc2NoZW1hL3NyYy9zY2hlbWEucnM=) | `92.21% <100.00%> (ø)` | | | [src/daft-logical-plan/src/source\_info/mod.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-logical-plan%2Fsrc%2Fsource_info%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtbG9naWNhbC1wbGFuL3NyYy9zb3VyY2VfaW5mby9tb2QucnM=) | `76.92% <95.00%> (+10.25%)` | :arrow_up: | | [src/daft-connect/src/lib.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvbGliLnJz) | `48.94% <33.33%> (+1.40%)` | :arrow_up: | | [src/daft-connect/src/main.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Fmain.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvbWFpbi5ycw==) | `0.00% <0.00%> (ø)` | | | [src/daft-connect/src/op/execute/root.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Fop%2Fexecute%2Froot.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvb3AvZXhlY3V0ZS9yb290LnJz) | `73.13% <73.13%> (ø)` | | | [src/daft-connect/src/op/execute/write.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Fop%2Fexecute%2Fwrite.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvb3AvZXhlY3V0ZS93cml0ZS5ycw==) | `80.00% <80.00%> (ø)` | | | [src/daft-connect/src/translation/logical\_plan.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuLnJz) | `44.73% <44.73%> (ø)` | | ... and [19 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3292/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)
graphite-app[bot] commented 4 days ago

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/20/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.