Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[CHORE]: better subquery handling #3295

Closed universalmind303 closed 1 week ago

universalmind303 commented 1 week ago

this better defers the errors to the optimizer instead of immediately erroring out on subqueries.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3295 will degrade performances by 56.18%

Comparing universalmind303:subquery-fix-2 (1896257) with main (711e862)

Summary

❌ 2 regressions ✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:subquery-fix-2 Change
test_iter_rows_first_row[100 Small Files] 269 ms 373.8 ms -28.03%
test_show[100 Small Files] 22.3 ms 50.8 ms -56.18%