Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[DOCS] Fix typo in limit example #3303

Closed colin-ho closed 6 days ago

codspeed-hq[bot] commented 6 days ago

CodSpeed Performance Report

Merging #3303 will degrade performances by 40.18%

Comparing colin/fix-limit-example (a37126f) with main (ca8f25d)

Summary

⚡ 1 improvements ❌ 1 regressions ✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main colin/fix-limit-example Change
test_iter_rows_first_row[100 Small Files] 369.1 ms 279.3 ms +32.12%
test_show[100 Small Files] 15 ms 25 ms -40.18%
codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.66%. Comparing base (ca8f25d) to head (a37126f). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3303/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3303 +/- ## ========================================== + Coverage 75.90% 77.66% +1.75% ========================================== Files 667 668 +1 Lines 83922 82100 -1822 ========================================== + Hits 63699 63761 +62 + Misses 20223 18339 -1884 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3303?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [daft/dataframe/dataframe.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3303?src=pr&el=tree&filepath=daft%2Fdataframe%2Fdataframe.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9kYXRhZnJhbWUvZGF0YWZyYW1lLnB5) | `86.65% <ø> (ø)` | | ... and [20 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3303/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)