Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[BUG] Fixes regexp_replace expression #3306

Closed ConeyLiu closed 5 days ago

ConeyLiu commented 1 week ago

regexp_replace should set regex to True

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3306 will degrade performances by 17.6%

Comparing ConeyLiu:fixes-regexp-replace (71991af) with main (84db665)

Summary

⚡ 2 improvements ❌ 1 regressions ✅ 14 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ConeyLiu:fixes-regexp-replace Change
test_count[1 Small File] 3.3 ms 4 ms -17.6%
test_iter_rows_first_row[100 Small Files] 421.4 ms 293 ms +43.83%
test_show[100 Small Files] 32.7 ms 24 ms +36.04%