Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT] connect: add `df.limit` and `df.first` #3309

Closed andrewgazelka closed 12 hours ago

andrewgazelka commented 2 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq[bot] commented 2 days ago

CodSpeed Performance Report

Merging #3309 will degrade performances by 48.97%

Comparing andrew/connect-first (e099f2e) with main (3394a66)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-first Change
test_iter_rows_first_row[100 Small Files] 324.1 ms 284 ms +14.11%
test_show[100 Small Files] 15.9 ms 31.2 ms -48.97%
codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (3394a66) to head (e099f2e). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/logical_plan.rs 87.50% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3309/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3309 +/- ## ======================================= Coverage 77.35% 77.35% ======================================= Files 685 685 Lines 83631 83639 +8 ======================================= + Hits 64695 64703 +8 Misses 18936 18936 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3309?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-connect/src/translation/logical\_plan.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3309?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuLnJz) | `71.42% <87.50%> (+9.89%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3309/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features:

andrewgazelka commented 12 hours ago

Merge activity