Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[FEAT] Add new workflow to build commits and output to s3 #3321

Closed raunakab closed 5 days ago

raunakab commented 6 days ago

Overview

Given a commit hash and a build machine, outputs a python wheel to s3. This is slightly different than existing one. Differences:

codspeed-hq[bot] commented 6 days ago

CodSpeed Performance Report

Merging #3321 will degrade performances by 19.86%

Comparing feat/build-commit-workflow (ca82ffa) with main (274f300)

Summary

⚡ 1 improvements ❌ 1 regressions ✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/build-commit-workflow Change
test_iter_rows_first_row[100 Small Files] 378.4 ms 258.6 ms +46.36%
test_show[100 Small Files] 23.9 ms 29.8 ms -19.86%
codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.38%. Comparing base (274f300) to head (ca82ffa). Report is 7 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3321/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3321 +/- ## ========================================== - Coverage 77.39% 77.38% -0.01% ========================================== Files 676 676 Lines 82604 82604 ========================================== - Hits 63928 63925 -3 - Misses 18676 18679 +3 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3321/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features:

raunakab commented 6 days ago

Running

Will be able to run via:

gh workflow run build-commit.yaml --ref my-branch-name

This does assume that you have the gh CLI tool installed. If you have a macOS or Linux system, you can install it via brew install gh. Once merged into main, you will also be able to manually trigger this via the GitHub Actions tab on the browser app.

Performance

Assuming a cache-miss, build times will usually be around 5-6min. Assuming a cache-hit, build times will usually be <40s.

raunakab commented 5 days ago

Closing in favour of https://github.com/Eventual-Inc/Daft/pull/3184.