Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[FEAT] Scaffolding for df.write_table #3323

Open jaychia opened 6 days ago

codspeed-hq[bot] commented 6 days ago

CodSpeed Performance Report

Merging #3323 will degrade performances by 27.54%

Comparing jay/write-table (0cf9c19) with main (dc42571)

Summary

⚡ 1 improvements ❌ 1 regressions ✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jay/write-table Change
test_iter_rows_first_row[100 Small Files] 382.9 ms 329.3 ms +16.28%
test_show[100 Small Files] 23.9 ms 33 ms -27.54%
codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (bb506a4) to head (0cf9c19). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
daft/dataframe/dataframe.py 66.66% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3323/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3323 +/- ## ======================================= Coverage 77.38% 77.38% ======================================= Files 676 676 Lines 82602 82607 +5 ======================================= + Hits 63922 63928 +6 + Misses 18680 18679 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3323?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [daft/dataframe/dataframe.py](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3323?src=pr&el=tree&filepath=daft%2Fdataframe%2Fdataframe.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-ZGFmdC9kYXRhZnJhbWUvZGF0YWZyYW1lLnB5) | `86.58% <66.66%> (-0.07%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3323/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features: