[FEAT] connect: collect

[andrewgazelka]

• #3326 👈 (View in Graphite)
• #3341 : 3 other dependent PRs (#3309 , #3342 , #3343 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq[bot]]

CodSpeed Performance Report

Merging #3326 will improve performances by 61.17%

_{Comparing andrew/connect-collect (099354a) with main (5fee192)}

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	andrew/connect-collect	Change
⚡	test_show[100 Small Files]	24.2 ms	15 ms	+61.17%

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.26%. Comparing base (5fee192) to head (099354a). Report is 1 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3326 +/- ## ========================================== - Coverage 77.41% 77.26% -0.16% ========================================== Files 678 678 Lines 83680 83476 -204 ========================================== - Hits 64783 64495 -288 - Misses 18897 18981 +84 ``` [see 16 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3326/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[kevinzwang]

@andrewgazelka should this PR have the implementation of collect in it? I only see the test

[andrewgazelka]

It is implemented as part of the client library and not the server, so we need no implementation to get it to work.

[andrewgazelka]

Merge activity

• Nov 20, 7:38 PM EST: A user started a stack merge that includes this pull request via Graphite.
• Nov 20, 7:38 PM EST: A user merged this pull request with Graphite.