Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust

https://getdaft.io

Apache License 2.0

2.34k stars 164 forks source link

[FEAT] add workflow to run tpch benchmarking #3328

Closed raunakab closed 2 days ago

raunakab commented 3 days ago

Overview

Add a GitHub Actions workflow to only run tpch benchmarks given a commit-sha and a wheel name.

the logic will look at the appropriate AWS S3 bucket given those two inputs and find the correct wheel
then it will spawn a ray-cluster and run daft against the given tpch benchmarks

Note

I am merging this into feat/build-commit-workflow, and I will then merge that final branch into main. This is to help segment the purposes of each workflow, since they are highly reusable.

codspeed-hq[bot] commented 3 days ago

CodSpeed Performance Report

Merging #3328 will improve performances by 34.38%

_{Comparing feat/run-tpch (8a5b668) with feat/build-commit-workflow (ca82ffa)}

Summary

⚡ 2 improvements ✅ 15 untouched benchmarks

Benchmarks breakdown

	Benchmark	`feat/build-commit-workflow`	`feat/run-tpch`	Change
⚡	`test_iter_rows_first_row[100 Small Files]`	258.6 ms	195.1 ms	+32.54%
⚡	`test_show[100 Small Files]`	29.8 ms	22.2 ms	+34.38%

jaychia commented 2 days ago

Is this ready for review? If it is, can we move it out of the draft state?

raunakab commented 2 days ago

Closing in favour of https://github.com/Eventual-Inc/Daft/pull/3184.