search

Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[BUG]: tbl alias with join #3333

Closed universalmind303 closed 2 days ago

universalmind303 commented 2 days ago

closes https://github.com/Eventual-Inc/Daft/issues/3311

codspeed-hq[bot] commented 2 days ago

CodSpeed Performance Report

Merging #3333 will degrade performances by 41.38%

Comparing universalmind303:tbl-alias-bug (537919a) with main (1b84250)

Summary

❌ 1 regressions ✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:tbl-alias-bug Change
❌ test_show[100 Small Files] 24.1 ms 41.2 ms -41.38%
codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (824df2c) to head (537919a). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-sql/src/planner.rs 75.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3333/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3333 +/- ## ========================================== - Coverage 77.38% 77.32% -0.07% ========================================== Files 676 677 +1 Lines 82604 82808 +204 ========================================== + Hits 63926 64029 +103 - Misses 18678 18779 +101 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3333?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-sql/src/planner.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3333?src=pr&el=tree&filepath=src%2Fdaft-sql%2Fsrc%2Fplanner.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtc3FsL3NyYy9wbGFubmVyLnJz) | `68.03% <75.00%> (-0.03%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3333/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features:

ukclivecox commented 1 day ago

Thanks!