Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT]: allow for implicit coercion between str & date #3337

Closed universalmind303 closed 1 day ago

codspeed-hq[bot] commented 2 days ago

CodSpeed Performance Report

Merging #3337 will degrade performances by 34.15%

Comparing universalmind303:date-casting (4dcda56) with main (a9bf7c0)

Summary

❌ 1 regressions ✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:date-casting Change
test_iter_rows_first_row[100 Small Files] 226.6 ms 344.1 ms -34.15%
codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.37%. Comparing base (a9bf7c0) to head (4dcda56). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3337/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3337 +/- ## ======================================= Coverage 77.37% 77.37% ======================================= Files 677 677 Lines 82864 82867 +3 ======================================= + Hits 64113 64120 +7 + Misses 18751 18747 -4 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3337?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-core/src/datatypes/infer\_datatype.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3337?src=pr&el=tree&filepath=src%2Fdaft-core%2Fsrc%2Fdatatypes%2Finfer_datatype.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29yZS9zcmMvZGF0YXR5cGVzL2luZmVyX2RhdGF0eXBlLnJz) | `81.56% <100.00%> (+0.03%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3337/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features: