Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT] consolidate Spark session fixture into conftest.py #3341

Closed andrewgazelka closed 1 day ago

andrewgazelka commented 1 day ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq[bot] commented 1 day ago

CodSpeed Performance Report

Merging #3341 will degrade performances by 31.95%

Comparing andrew/connect-consolidate-session (008b377) with main (ec24c80)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-consolidate-session Change
test_iter_rows_first_row[100 Small Files] 192.3 ms 282.6 ms -31.95%
codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.42%. Comparing base (ec24c80) to head (008b377). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/lib.rs 85.18% 4 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3341/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3341 +/- ## ======================================= Coverage 77.41% 77.42% ======================================= Files 678 678 Lines 83216 83233 +17 ======================================= + Hits 64423 64441 +18 + Misses 18793 18792 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3341?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-connect/src/lib.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3341?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvbGliLnJz) | `49.75% <85.18%> (+3.47%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3341/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features:

andrewgazelka commented 23 hours ago

Merge activity