Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT] connect: add alias support #3342

Closed andrewgazelka closed 19 hours ago

andrewgazelka commented 1 day ago

To be "fully" 1:1 will need

andrewgazelka commented 1 day ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq[bot] commented 1 day ago

CodSpeed Performance Report

Merging #3342 will degrade performances by 18.45%

Comparing andrew/connect-alias (3402dc6) with main (2c0f3cd)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-alias Change
test_iter_rows_first_row[100 Small Files] 289.2 ms 354.7 ms -18.45%
codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 26.00000% with 259 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (f6eb993) to head (3402dc6). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/datatype.rs 7.40% 100 Missing :warning:
...-connect/src/translation/logical_plan/aggregate.rs 0.00% 44 Missing :warning:
src/daft-connect/src/translation/literal.rs 0.00% 33 Missing :warning:
...onnect/src/translation/expr/unresolved_function.rs 0.00% 31 Missing :warning:
src/daft-connect/src/translation/expr.rs 54.38% 26 Missing :warning:
...daft-connect/src/translation/logical_plan/range.rs 62.50% 18 Missing :warning:
src/daft-dsl/src/lit.rs 0.00% 3 Missing :warning:
src/daft-connect/src/translation/logical_plan.rs 33.33% 2 Missing :warning:
src/daft-connect/src/lib.rs 80.00% 1 Missing :warning:
...ft-connect/src/translation/logical_plan/project.rs 88.88% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3342 +/- ## ========================================== - Coverage 77.44% 77.35% -0.10% ========================================== Files 678 685 +7 Lines 83309 83629 +320 ========================================== + Hits 64519 64689 +170 - Misses 18790 18940 +150 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-connect/src/translation/schema.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Fschema.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vc2NoZW1hLnJz) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [src/daft-connect/src/lib.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvbGliLnJz) | `64.21% <80.00%> (+14.45%)` | :arrow_up: | | [...ft-connect/src/translation/logical\_plan/project.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan%2Fproject.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuL3Byb2plY3QucnM=) | `88.88% <88.88%> (ø)` | | | [src/daft-connect/src/translation/logical\_plan.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuLnJz) | `61.53% <33.33%> (-2.26%)` | :arrow_down: | | [src/daft-dsl/src/lit.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-dsl%2Fsrc%2Flit.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtZHNsL3NyYy9saXQucnM=) | `56.28% <0.00%> (-0.49%)` | :arrow_down: | | [...daft-connect/src/translation/logical\_plan/range.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan%2Frange.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuL3JhbmdlLnJz) | `62.50% <62.50%> (ø)` | | | [src/daft-connect/src/translation/expr.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Fexpr.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vZXhwci5ycw==) | `54.38% <54.38%> (ø)` | | | [...onnect/src/translation/expr/unresolved\_function.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Fexpr%2Funresolved_function.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vZXhwci91bnJlc29sdmVkX2Z1bmN0aW9uLnJz) | `0.00% <0.00%> (ø)` | | | [src/daft-connect/src/translation/literal.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Fliteral.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbGl0ZXJhbC5ycw==) | `0.00% <0.00%> (ø)` | | | [...-connect/src/translation/logical\_plan/aggregate.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan%2Faggregate.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuL2FnZ3JlZ2F0ZS5ycw==) | `0.00% <0.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3342/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features:

graphite-app[bot] commented 21 hours ago

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

andrewgazelka commented 21 hours ago

Merge activity