Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.35k stars 166 forks source link

[FEAT] connect: Add support for `select` #3344

Closed andrewgazelka closed 3 days ago

andrewgazelka commented 4 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq[bot] commented 3 days ago

CodSpeed Performance Report

Merging #3344 will degrade performances by 39.66%

Comparing andrew/connect-select (981e2e7) with main (cbe9d3b)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-select Change
test_show[100 Small Files] 15 ms 24.8 ms -39.66%
graphite-app[bot] commented 3 days ago

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

andrewgazelka commented 3 days ago

Merge activity

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.35%. Comparing base (cbe9d3b) to head (981e2e7). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3344/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3344 +/- ## ======================================= Coverage 77.35% 77.35% ======================================= Files 685 685 Lines 83639 83639 ======================================= Hits 64702 64702 Misses 18937 18937 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3344/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features: