Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FIX] .count() ... WIP #3348

Open andrewgazelka opened 1 day ago

andrewgazelka commented 1 day ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 19 hours ago

This PR is being prevented from merging because you need at least one of the required labels:

enhancement | performance | bug | chore | documentation | dependencies

The canonical and easiest way of adding them is to add the following prefixes to your PR title:

Thanks for helping us categorize and manage our PRs!

graphite-app[bot] commented 19 hours ago

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

codspeed-hq[bot] commented 19 hours ago

CodSpeed Performance Report

Merging #3348 will degrade performances by 26.2%

Comparing andrew/connect-fix-count (a55f5aa) with main (e236332)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-fix-count Change
test_iter_rows_first_row[100 Small Files] 330.7 ms 367.6 ms -10.04%
test_show[100 Small Files] 15.5 ms 21 ms -26.2%