Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT]: connect: `df.sort` #3357

Open andrewgazelka opened 1 day ago

andrewgazelka commented 1 day ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq[bot] commented 18 hours ago

CodSpeed Performance Report

Merging #3357 will degrade performances by 37.44%

Comparing andrew/connect-sort (fda0158) with main (e236332)

Summary

⚑ 1 improvements
❌ 1 regressions
βœ… 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-sort Change
⚑ test_iter_rows_first_row[100 Small Files] 330.7 ms 278.3 ms +18.83%
❌ test_show[100 Small Files] 15.5 ms 24.8 ms -37.44%
graphite-app[bot] commented 18 hours ago

Graphite Automations

"Notify author when CI fails" took an action on this PR β€’ (11/21/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

codecov[bot] commented 18 hours ago

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (3394a66) to head (a8158bd).

Files with missing lines Patch % Lines
.../daft-connect/src/translation/logical_plan/sort.rs 82.60% 8 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3357/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3357 +/- ## ======================================= Coverage 77.35% 77.36% ======================================= Files 685 686 +1 Lines 83631 83676 +45 ======================================= + Hits 64695 64732 +37 - Misses 18936 18944 +8 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3357?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Ξ” | | |---|---|---| | [src/daft-connect/src/translation/logical\_plan.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3357?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuLnJz) | `64.28% <100.00%> (+2.74%)` | :arrow_up: | | [.../daft-connect/src/translation/logical\_plan/sort.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3357?src=pr&el=tree&filepath=src%2Fdaft-connect%2Fsrc%2Ftranslation%2Flogical_plan%2Fsort.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtY29ubmVjdC9zcmMvdHJhbnNsYXRpb24vbG9naWNhbF9wbGFuL3NvcnQucnM=) | `82.60% <82.60%> (ΓΈ)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3357/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features: