Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT]: sql HAVING #3364

Closed universalmind303 closed 1 day ago

codspeed-hq[bot] commented 1 day ago

CodSpeed Performance Report

Merging #3364 will improve performances by 83.54%

Comparing universalmind303:sql-having (b011517) with main (bdfb8c6)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main universalmind303:sql-having Change
test_iter_rows_first_row[100 Small Files] 362 ms 197.2 ms +83.54%
test_show[100 Small Files] 33 ms 23.8 ms +38.76%
codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.42%. Comparing base (b89ee3d) to head (413b906). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3364/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3364 +/- ## ========================================== - Coverage 77.42% 77.42% -0.01% ========================================== Files 678 678 Lines 83213 83234 +21 ========================================== + Hits 64431 64444 +13 - Misses 18782 18790 +8 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3364?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-sql/src/planner.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3364?src=pr&el=tree&filepath=src%2Fdaft-sql%2Fsrc%2Fplanner.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtc3FsL3NyYy9wbGFubmVyLnJz) | `70.64% <100.00%> (+0.43%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3364/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features: