Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[DOCS] Add docs pointing to `daft-launcher` #3369

Open raunakab opened 1 day ago

raunakab commented 1 day ago

Overview

Added a small section pointing towards daft-launcher and how to install/use it. Added it underneath the distributed-computing section.

codspeed-hq[bot] commented 1 day ago

CodSpeed Performance Report

Merging #3369 will degrade performances by 32.94%

Comparing docs/add-launcher-docs (e5b209d) with main (3394a66)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main docs/add-launcher-docs Change
test_count[1 Small File] 3.8 ms 3.5 ms +10.96%
test_iter_rows_first_row[100 Small Files] 324.1 ms 279.8 ms +15.83%
test_show[100 Small Files] 15.9 ms 23.7 ms -32.94%
graphite-app[bot] commented 1 day ago

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (11/20/24)

1 reviewer was added to this PR based on Andrew Gazelka's automation.

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.62%. Comparing base (3394a66) to head (e5b209d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3369/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3369 +/- ## ========================================== - Coverage 77.35% 76.62% -0.74% ========================================== Files 685 684 -1 Lines 83631 85735 +2104 ========================================== + Hits 64695 65696 +1001 - Misses 18936 20039 +1103 ``` [see 16 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3369/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features:

github-actions[bot] commented 17 hours ago

🚀 Deployed on https://deploy-preview-3369--daft-docs-preview.netlify.app

ccmao1130 commented 17 hours ago

For MVP it looks good to me, but I think there's a better way we can incorporate Daft Launcher in the Distributed Computing page because right now (besides looking at the left menu) users have to scroll all the way to the bottom to click to the section.

Have you also thought about how/where to reference Daft Launcher on the Ray page? https://www.getdaft.io/projects/docs/en/stable/user_guide/integrations/ray.html

raunakab commented 16 hours ago

For MVP it looks good to me, but I think there's a better way we can incorporate Daft Launcher in the Distributed Computing page because right now (besides looking at the left menu) users have to scroll all the way to the bottom to click to the section.

Have you also thought about how/where to reference Daft Launcher on the Ray page? https://www.getdaft.io/projects/docs/en/stable/user_guide/integrations/ray.html

I can add it there if needed. Just didn't know that that was something that we wanted.

raunakab commented 16 hours ago

CodSpeed Performance Report

Merging #3369 will degrade performances by 32.94%

Comparing docs/add-launcher-docs (e5b209d) with main (3394a66)

Summary

⚡ 2 improvements ❌ 1 regressions ✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main docs/add-launcher-docs Change ⚡ test_count[1 Small File] 3.8 ms 3.5 ms +10.96% ⚡ test_iter_rows_first_row[100 Small Files] 324.1 ms 279.8 ms +15.83% ❌ test_show[100 Small Files] 15.9 ms 23.7 ms -32.94%

I'm just changing some docs! Argh!

ccmao1130 commented 3 hours ago

Hmm maybe just add something like "To run Daft on a distributed Ray cluster, see Daft Launcher [link to Daft Launcher docs on Daft docs]" wherever you see fit on the Ray page (maybe either right before "Usage" section or at the bottom of the page)