Open raunakab opened 1 day ago
Comparing docs/add-launcher-docs
(e5b209d) with main
(3394a66)
⚡ 2
improvements
❌ 1
regressions
✅ 14
untouched benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmark | main |
docs/add-launcher-docs |
Change | |
---|---|---|---|---|
⚡ | test_count[1 Small File] |
3.8 ms | 3.5 ms | +10.96% |
⚡ | test_iter_rows_first_row[100 Small Files] |
324.1 ms | 279.8 ms | +15.83% |
❌ | test_show[100 Small Files] |
15.9 ms | 23.7 ms | -32.94% |
1 reviewer was added to this PR based on Andrew Gazelka's automation.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.62%. Comparing base (
3394a66
) to head (e5b209d
).
🚨 Try these New Features:
For MVP it looks good to me, but I think there's a better way we can incorporate Daft Launcher in the Distributed Computing page because right now (besides looking at the left menu) users have to scroll all the way to the bottom to click to the section.
Have you also thought about how/where to reference Daft Launcher on the Ray page? https://www.getdaft.io/projects/docs/en/stable/user_guide/integrations/ray.html
For MVP it looks good to me, but I think there's a better way we can incorporate Daft Launcher in the Distributed Computing page because right now (besides looking at the left menu) users have to scroll all the way to the bottom to click to the section.
Have you also thought about how/where to reference Daft Launcher on the Ray page? https://www.getdaft.io/projects/docs/en/stable/user_guide/integrations/ray.html
I can add it there if needed. Just didn't know that that was something that we wanted.
CodSpeed Performance Report
Merging #3369 will degrade performances by 32.94%
Comparing
docs/add-launcher-docs
(e5b209d) withmain
(3394a66)Summary
⚡ 2
improvements❌ 1
regressions✅ 14
untouched benchmarks⚠️ Please fix the performance issues or acknowledge them on CodSpeed.
Benchmarks breakdown
Benchmark
main
docs/add-launcher-docs
Change ⚡test_count[1 Small File]
3.8 ms 3.5 ms +10.96% ⚡test_iter_rows_first_row[100 Small Files]
324.1 ms 279.8 ms +15.83% ❌test_show[100 Small Files]
15.9 ms 23.7 ms -32.94%
I'm just changing some docs! Argh!
Hmm maybe just add something like "To run Daft on a distributed Ray cluster, see Daft Launcher [link to Daft Launcher docs on Daft docs]" wherever you see fit on the Ray page (maybe either right before "Usage" section or at the bottom of the page)
Overview
Added a small section pointing towards daft-launcher and how to install/use it. Added it underneath the
distributed-computing
section.