Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT] connect: add tests for `df.take()` method #3385

Open andrewgazelka opened 19 hours ago

andrewgazelka commented 19 hours ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq[bot] commented 7 hours ago

CodSpeed Performance Report

Merging #3385 will degrade performances by 62.18%

Comparing andrew/connect-take (0693f3f) with main (e236332)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-take Change
test_iter_rows_first_row[100 Small Files] 330.7 ms 234.8 ms +40.85%
test_show[100 Small Files] 15.5 ms 41 ms -62.18%
codecov[bot] commented 7 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.36%. Comparing base (e236332) to head (0693f3f).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3385/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3385 +/- ## ======================================= Coverage 77.36% 77.36% ======================================= Files 685 685 Lines 83639 83639 ======================================= Hits 64704 64704 Misses 18935 18935 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3385/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features: