Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[CHORE] Pin PyIceberg version to <0.8 #3391

Closed kevinzwang closed 12 hours ago

kevinzwang commented 14 hours ago

Pinning because PyIceberg changes some internal APIs in v0.8 that we currently use, which breaks our use case. Tracking progress on a fix in #3394

codspeed-hq[bot] commented 14 hours ago

CodSpeed Performance Report

Merging #3391 will degrade performances by 33.12%

Comparing kevin/pin-pyiceberg (1e97cf6) with main (e236332)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kevin/pin-pyiceberg Change
test_iter_rows_first_row[100 Small Files] 330.7 ms 286.5 ms +15.42%
test_show[100 Small Files] 15.5 ms 23.2 ms -33.12%
graphite-app[bot] commented 14 hours ago

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (11/21/24)

1 reviewer was added to this PR based on Andrew Gazelka's automation.

codecov[bot] commented 14 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.35%. Comparing base (e236332) to head (1e97cf6). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3391/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3391 +/- ## ========================================== - Coverage 77.36% 77.35% -0.01% ========================================== Files 685 685 Lines 83639 83639 ========================================== - Hits 64704 64703 -1 - Misses 18935 18936 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3391/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features: