search

Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[CHORE] Simplify plan_aggregate_query and plan_non_agg_query in SQLPlanner #3395

Open kevinzwang opened 12 hours ago

kevinzwang commented 12 hours ago

With the alias_map in SQLPlanner I think we can simplify a lot of the query planning logic to rely on that, particularly because SQLPlanner.plan_expr should always return expressions that have columns in the current schema after the changes made in https://github.com/Eventual-Inc/Daft/pull/3304 for correlated subqueries

codspeed-hq[bot] commented 12 hours ago

CodSpeed Performance Report

Merging #3395 will degrade performances by 24.83%

Comparing kevin/simplify-plan-query (369eab0) with main (ec39dc0)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kevin/simplify-plan-query Change
❌ test_show[100 Small Files] 24.9 ms 33.1 ms -24.83%