Eventual-Inc / Daft

Distributed data engine for Python/SQL designed for the cloud, powered by Rust
https://getdaft.io
Apache License 2.0
2.34k stars 164 forks source link

[FEAT] Enable group by keys in aggregation expressions #3399

Open kevinzwang opened 8 hours ago

codspeed-hq[bot] commented 8 hours ago

CodSpeed Performance Report

Merging #3399 will improve performances by 68.39%

Comparing kevin/groupby-key-in-agg (d23e167) with main (ec39dc0)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main kevin/groupby-key-in-agg Change
test_show[100 Small Files] 24.9 ms 14.8 ms +68.39%
codecov[bot] commented 8 hours ago

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (ec39dc0) to head (d23e167).

Files with missing lines Patch % Lines
src/daft-dsl/src/resolve_expr/mod.rs 92.30% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3399/graphs/tree.svg?width=650&height=150&src=pr&token=J430QVFE89&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) ```diff @@ Coverage Diff @@ ## main #3399 +/- ## ========================================== + Coverage 76.54% 77.35% +0.81% ========================================== Files 685 685 Lines 85269 83647 -1622 ========================================== - Hits 65266 64706 -560 + Misses 20003 18941 -1062 ``` | [Files with missing lines](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3399?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc) | Coverage Δ | | |---|---|---| | [src/daft-logical-plan/src/ops/agg.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3399?src=pr&el=tree&filepath=src%2Fdaft-logical-plan%2Fsrc%2Fops%2Fagg.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtbG9naWNhbC1wbGFuL3NyYy9vcHMvYWdnLnJz) | `60.86% <100.00%> (+2.73%)` | :arrow_up: | | [src/daft-logical-plan/src/ops/pivot.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3399?src=pr&el=tree&filepath=src%2Fdaft-logical-plan%2Fsrc%2Fops%2Fpivot.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtbG9naWNhbC1wbGFuL3NyYy9vcHMvcGl2b3QucnM=) | `71.83% <100.00%> (+1.24%)` | :arrow_up: | | [src/daft-dsl/src/resolve\_expr/mod.rs](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3399?src=pr&el=tree&filepath=src%2Fdaft-dsl%2Fsrc%2Fresolve_expr%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc#diff-c3JjL2RhZnQtZHNsL3NyYy9yZXNvbHZlX2V4cHIvbW9kLnJz) | `90.33% <92.30%> (+0.16%)` | :arrow_up: | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/Eventual-Inc/Daft/pull/3399/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eventual-Inc)

🚨 Try these New Features:

graphite-app[bot] commented 8 hours ago

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (11/22/24)

1 reviewer was added to this PR based on Andrew Gazelka's automation.