Eventuous / eventuous

Event Sourcing library for .NET
https://eventuous.dev
Apache License 2.0
447 stars 71 forks source link

[Mongo] Add bulk support to projections #241

Closed makp0 closed 11 months ago

alexeyzimarev commented 1 year ago

Just thinking if it would make more sense for bulk ops if we add a batching filter?

makp0 commented 1 year ago

Just thinking if it would make more sense for bulk ops if we add a batching filter?

Could you elaborate on what exactly is on your mind?

But prior, I try guessing, hoping I got you. Do you mean batch size configuration?

makp0 commented 1 year ago

Anticipating chunking, did this one get obsoleted by .net 6? https://github.com/Eventuous/eventuous/blob/3209ab37dafee320fc563620665e0c06f6c15be1/src/Core/src/Eventuous.Producers/Chunk.cs#L7

alexeyzimarev commented 1 year ago

Anticipating chunking, did this one get obsoleted by .net 6?

https://github.com/Eventuous/eventuous/blob/3209ab37dafee320fc563620665e0c06f6c15be1/src/Core/src/Eventuous.Producers/Chunk.cs#L7

Hmm, not sure. Is it now built in?

alexeyzimarev commented 1 year ago

Just thinking if it would make more sense for bulk ops if we add a batching filter?

Could you elaborate on what exactly is on your mind?

But prior, I try guessing, hoping I got you. Do you mean batch size configuration?

I meant I thought it would be possible to create a batching generic filter. However, I am looking at the consume context now and it has too much single-message focus. I don't like it very much, need to think about it. I guess, we can move on as-is with the PR, and I'll get back to generic batching later.

makp0 commented 1 year ago

Anticipating chunking, did this one get obsoleted by .net 6? https://github.com/Eventuous/eventuous/blob/3209ab37dafee320fc563620665e0c06f6c15be1/src/Core/src/Eventuous.Producers/Chunk.cs#L7

Hmm, not sure. Is it now built in?

yes https://learn.microsoft.com/en-us/dotnet/api/system.linq.enumerable.chunk?view=net-7.0

makp0 commented 1 year ago

Just thinking if it would make more sense for bulk ops if we add a batching filter?

Could you elaborate on what exactly is on your mind? But prior, I try guessing, hoping I got you. Do you mean batch size configuration?

I meant I thought it would be possible to create a batching generic filter. However, I am looking at the consume context now and it has too much single-message focus. I don't like it very much, need to think about it. I guess, we can move on as-is with the PR, and I'll get back to generic batching later.

If batch has Insert operations, they ignore filter?

alexeyzimarev commented 1 year ago

If you rebase with latest, the issue should be gone from the tests.

makp0 commented 1 year ago

If you rebase with latest, the issue should be gone from the tests.

Nope, still there

makp0 commented 1 year ago

@alexeyzimarev , what's the status of this PR?

alexeyzimarev commented 1 year ago

Please hang on, I am a bit busy with other things. Sorry about the delay.

alexeyzimarev commented 11 months ago

@makp0 are you ok to have a call one of these days to discuss the PR? I am thinking if the API can be improved :)

github-actions[bot] commented 11 months ago

Test Results

0 tests   0 :heavy_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit d727a75f.