search

Eventuous / eventuous

Event Sourcing library for .NET
https://eventuous.dev
Apache License 2.0
442 stars 70 forks source link

Make AsActionResult virtual #289

Closed LockTar closed 9 months ago

LockTar commented 9 months ago

Make AsActionResult virtual. This PR can be ignored if #288 is approved.

github-actions[bot] commented 9 months ago

Test Results

  32 files   -   16    32 suites   - 16   9m 59s :stopwatch: -40s 132 tests  -     2  132 :heavy_check_mark:  -     2  0 :zzz: ±0  0 :x: ±0  260 runs   - 130  260 :heavy_check_mark:  - 130  0 :zzz: ±0  0 :x: ±0 

Results for commit 1269bc80. ± Comparison against base commit a66fb591.

This pull request removes 6 and adds 4 tests. Note that renamed tests count towards both. ``` Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext = }) ``` ``` Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext = }) ```