search

Eventuous / eventuous

Event Sourcing library for .NET
https://eventuous.dev
Apache License 2.0
442 stars 70 forks source link

Amend events when saving #301

Closed Lejdholt closed 4 days ago

Lejdholt commented 9 months ago

I want to add metadata that is available in scope, correlationid, causationId , currentuser etc. This might be away to do it. I'm still thinking on how to do it on the handler side

github-actions[bot] commented 9 months ago

Test Results

  51 files  +  34    51 suites  +34   16m 7s :stopwatch: + 11m 40s 146 tests +    5  130 :heavy_check_mark:  -     7  0 :zzz: ±0  16 :x: +12  426 runs  +285  378 :heavy_check_mark: +241  0 :zzz: ±0  48 :x: +44 

For more details on these failures, see this check.

Results for commit 73aa42c0. ± Comparison against base commit 0be16566.

This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both. ``` Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-11-24T15:37:15.8352102+00:00 }) ``` ``` Eventuous.Tests.AmendStoringEvents ‑ StoreInitial Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:53.7628567+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:00:54.6241341+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2023-12-05T22:01:00.0833866+00:00 }) ```

:recycle: This comment has been updated with latest results.