search

Eventuous / eventuous

Event Sourcing library for .NET
https://eventuous.dev
Apache License 2.0
450 stars 71 forks source link

Clean up and remove commented code #353

Closed alexeyzimarev closed 3 months ago

alexeyzimarev commented 3 months ago

Follow up command services refactoring

github-actions[bot] commented 3 months ago

Test Results

 36 files  + 18   36 suites  +18   7m 32s :stopwatch: + 4m 15s 159 tests +  2  159 :white_check_mark: +  2  0 :zzz: ±0  0 :x: ±0  314 runs  +157  314 :white_check_mark: +157  0 :zzz: ±0  0 :x: ±0 

Results for commit be0121c8. ± Comparison against base commit 9f9313bb.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both. ``` Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-20T15:42:36.3216353+00:00 }) ``` ``` Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:45.7194153+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }, CommitPosition { Position: 0, Sequence: 4, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }) Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position: 0, Sequence: 1, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }, CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }, CommitPosition { Position: 0, Sequence: 6, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }, CommitPosition { Position: 0, Sequence: 8, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }], expected: CommitPosition { Position: 0, Sequence: 2, Timestamp: 2024-06-21T06:27:48.7057711+00:00 }) ```