search

EverNewJoy / VictoryPlugin

Rama's Victory BP Plugin
MIT License
867 stars 256 forks source link

No compatible with ue4.13 #7

Closed saidmoya12 closed 7 years ago

saidmoya12 commented 8 years ago

Now VictoryPlugin isn't compatible with the latest version of UE4

This version have some improvements for vr so will be great if could fix it

EverNewJoy commented 8 years ago

4.13 is a preview build, I've not yet been able to obtain it from the epic launcher, when I can get the launcher to download it it than I can check it out.

MadisonAster commented 8 years ago

There are only 2 issues preventing compile, one is a reference to WinRT in OperatingSystem__GetCurrentPlatform I can't find any mention of it in the release notes, but I imagine Epic has completely abandoned WinRT support because Microsoft has now officially abandoned it.

The second issue is with the findSource function. It appears WaveInstanceSourceMap was made a private member in FAudioDevice for 4.13. I don't quite understand what happened though because according to the log this change happened in february

https://github.com/EpicGames/UnrealEngine/blame/release/Engine/Source/Runtime/Engine/Public/AudioDevice.h

I don't have a fix for this, but in any event, I was able to get Victory to compile simply by commenting the function out. This should compile if you need to use 4.13 immediately

https://github.com/ThomasMcVay/VictoryPlugin/tree/413Bandaid

EverNewJoy commented 8 years ago

ahh thanks, yes I forgot to update the github to my latest, 1 moment :)

MadisonAster commented 8 years ago

Your new commit compiled just fine, working great. Thanks.

EverNewJoy commented 8 years ago

Yay!

Rama

Ajordan8907 commented 8 years ago

Hi Rama,

I'm getting an error trying to implement into 4.13 - the "plugin missing or incompatible" pop-up box followed by this pop-up: plugin failed

Is there something I'm missing?