Everblush / gtk

Everblush GTK theme made with Phocus
MIT License
51 stars 3 forks source link

Update Makefile #5

Closed paulhersch closed 2 years ago

paulhersch commented 2 years ago

the current makefile doesn't work, as there is no src folder anymore

Mangeshrex commented 2 years ago

Uhh ok I'll push the fix in an hour but till then you can just make a directory mkdir src If you see another error as no gtk.scss found then touch that file in respective dir.

These errors cause no issues on the theme

paulhersch commented 2 years ago

the all part in the Makefile does error out, no?

paulhersch commented 2 years ago

well it doesn't work for me because i use NixOS so there is no /usr directory... after writing my own derivation the builder originally failed because of the

all:
    mkdir -p gtk-3.0
    sass src/gtk-3.0/gtk.scss gtk-3.0/gtk.css

part in the Makefile. My current build instruction looks like this

        preBuild = ''
        mkdir -p $out/share/themes/Everblush-gtk/gtk-3.0
    '';
    buildPhase = ''
        runHook preBuild
                sass $src/sass/gtk-3.0/gtk.scss $out/share/themes/Everblush-gtk/gtk-3.0/gtk.css
    '';
    installPhase = ''
        cp -n -r $src/* $out/share/themes/Everblush-gtk/
    '';

which works. Thats why i opened this issue, the command sass src/gtk-3.0/gtk.scss gtk-3.0/gtk.css in the original makefile just didnt work

Mangeshrex commented 2 years ago

ohh have you got that working ? if so i would be happy if you make a pr which has a fix for NixOS Users.

paulhersch commented 2 years ago

i mean i just wrote a small derivation so that i could have it hardcoded in my config (so its basically "packaged" if you can say that).

btw i think i found some weirdness (idk if this is intended or not) but using the thing above actually creates another theme that is not everblush, pcmanfm for scale:

with sass build command thingy: 07-04-210939

without sass build command: 07-04-211128

i think you are overwriting the transscripted css with the current Makefile (which doesn't make sense, but creates the correct theme), but i have never touched a Makefile so I am not entirely sure.

paulhersch commented 2 years ago

closing this as it doesn't seem to affect normal installations