search

Everblush / nvim

A port of everblush.vim but written in lua
MIT License
239 stars 17 forks source link

Add an option to disable background color #12

Closed AlexLov closed 2 years ago

diniamo commented 2 years ago

https://www.reddit.com/r/neovim/comments/3v06lo/making_the_background_transparent/ or if the above doesn't work: https://forum.archlabslinux.com/t/make-vim-background-transparent-so-you-can-see-terminal/5023

imo it's not the plugins job to manage the background color

AlexLov commented 2 years ago

But the plugin still manage background color so why not to add the option? It's not quite convenient to override all the highlight groups declared in the plugin just to disable background color, it's just much easier to do it in the plugin's code. And yes it actually does what described in those links, and a little bit more.

diniamo commented 2 years ago

I know what it does, I looked at the code.

If it's better managed by the plugin, then why don't most themes do it?

Mangeshrex commented 2 years ago

How many user's would override Everblush background or make it transperant? As far as I know most user's would use the default Everblush background.

Mangeshrex commented 2 years ago

@AlexLov reply me whenever you're free.

AlexLov commented 2 years ago

@Mangeshrex at least one user (me) will use it. And I’m fine to have it in my fork if you against this.