search

Everduin94 / better-commits

A CLI for creating better commits following the conventional commits specification
MIT License
1.96k stars 69 forks source link

Default "max_items" value set to null #107

Closed AlexHodson closed 4 months ago

AlexHodson commented 4 months ago

Just tried to install on a new machine and when I first run the "better-commits" command. The following response was given:

Found global config │ ■ Invalid Configuration: commit_type.max_items │ Invalid type: Expected number but received null

I've had a look into the base global configuration file and for both commit_type.max_items & commit_scope.max_items are both set to null by default. Tried inputting the default configuration provided in the README, but the compains about "Infinity". Only way I can resolve this is to hardcode the max_items property to a specific number.

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 1.15.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Everduin94 commented 4 months ago

@AlexHodson - Thanks for catching / reporting this!

I didn't test defaults on a PR someone submitted. I goofed 🤦. Infinity on number never works with Valibot and the prop didn't have a min number validator either.