perf(branch): #57 replace zod with valibot

Everduin94 / better-commits

A CLI for creating better commits following the conventional commits specification

MIT License

1.88k stars 69 forks source link

perf(branch): #57 replace zod with valibot #89

Closed ravvi-kumar closed 2 months ago

Everduin94 commented 2 months ago

Hey @ravvi-kumar, sorry this took me forever to circle back to. Also sorry for this inconvenience, can you rebase? I added a default prettier config and ran the formatter so I'll be able to see just your changes.

Edit: Also I spent a good amount of time learning vali-bot since I last commented here, so I should be able to review / understand after rebase.

ravvi-kumar commented 2 months ago

Hi @Everduin94 ,

I've completed the rebase, but I intentionally skipped running Prettier to avoid introducing unnecessary formatting changes that might distract from the actual code changes. Please let me know if you see anything else that needs to be done. Since we're both familiar with Vali-Bot now, we can easily iterate if needed.

Everduin94 commented 2 months ago

For anyone who watches the repository or is checking out PRs. - If you want to pull down this branch and try to test it using

npm run start
npm run branch

That would be appreciated :)

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 1.15.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: