search

EverestAPI / CelesteTAS-EverestInterop

Everest interop for DevilSquirrel's CelesteTAS
https://github.com/EuniverseCat/CelesteTAS
MIT License
67 stars 28 forks source link

Improve Info HUD with entity information #32

Open XMinty77 opened 1 year ago

XMinty77 commented 1 year ago

This PR attempts to improve the Info HUD by displaying additional entity information

XMinty77 commented 1 year ago

The PR is not finished yet but I removed draft mode so it can be merged to main if needed.

DemoJameson commented 1 year ago

does UniqueEntityId.GlobalOrPersistent still need? it has never been read

XMinty77 commented 1 year ago

does UniqueEntityId.GlobalOrPersistent still need? it has never been read

it's not read but it serves as part of the comparison of UniqueEntityId records, namely for holdables you can transition with and for mod entities that are sometimes persistent and sometimes not so when it's different it distinguishes persistent entities of the same type vs non persistent entities I'm not sure because I haven't dealt with the uniqueness tracking system in a while but I think I kept this to solve a bug where the tracker gets confused when you bring a jelly through a transition then go back with it, now you have a duplicate version, and the unique ID alone doesn't distinguish them, but the persistence bool does distinguish them of course if you duplicate 3+ versions this breaks but I asked about this and it hasn't been reported yet to me an entity or a scenario where you would have 3 or more duplicates in the same room (it's definitely impossible without a glitch in vanilla)

psyGamer commented 4 weeks ago

Do you still plan on continuing with this PR? Also this PRs seems to change various other things not related to the custom info? Did you intend on doing that or did that came from messing something up with git? Additionally this PR would need to be re-targeted onto master due to the various Studio v3 changes. It might make sense to start fresh and copy the relevant things to avoid messy merge conflics and to not have a messy commit history.