EverestAPI / CelesteTAS-EverestInterop

Everest interop for DevilSquirrel's CelesteTAS
https://github.com/EuniverseCat/CelesteTAS
MIT License
67 stars 28 forks source link

Bugfix: in InfoCustom, empty memberNames crashes the game #49

Closed LozenChen closed 1 year ago

LozenChen commented 1 year ago

{Player.toFrame():} will crashes the game as after identifying toFrame() as a helperMethod, memberNames become empty, and is never checked. Then calling memberNames.First() will crash the game

bugfix: memberNames empty exception feat: Add GetAssembly() helperMethod support Collider in FormatValue rewrite FormatValue to make it more extensible

DemoJameson commented 1 year ago

can you rename GetAssembly() to GetModName() you can determine if the type has the same assembly in Everest.modules and get the mod name also update the readme.md

LozenChen commented 1 year ago

updated a minor bug (not tested but should exist): for objects from Everest or some EverestModules automatically created by Everest (e.g. LuaModule), object.GetModName() will be "Celeste"

DemoJameson commented 1 year ago

I think the get mod name feature fits better in the console info, so I moved it

LozenChen commented 1 year ago

wow i don't even know that feature exists, that's nice